Add #![feature(const_fn_floating_point_arithmetic)]
#77122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
Sep 24, 2020
I'm in full agreement that we should do this and eliminate the r=me with Ralf's nit |
ecstatic-morse
force-pushed
the
const-fn-arithmetic
branch
from
35d6107
to
a4fe056
Compare
|
@bors r=oli-obk,RalfJung |
|
📌 Commit a4fe056e70fcbdc303b8709699ed38d92d0b888b has been approved by |
bors
added
S-waiting-on-bors
|
cc #57241 |
|
☔ The latest upstream changes (presumably #77172) made this pull request unmergeable. Please resolve the merge conflicts. Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels: |
bors
added
S-waiting-on-author
This refactors handling of `Rvalue::{Unary,Binary}Op` in the
const-checker. Now we `span_bug` if there's an unexpected type in a
primitive operation. This also allows unary negation on
`char` values through the const-checker because it makes the code a bit
cleaner. `char` does not actually support these operations, and if it
did, we could evaluate them at compile-time.
ecstatic-morse
force-pushed
the
const-fn-arithmetic
branch
from
a4fe056
to
659028f
Compare
|
@bors r=RalfJung,oli-obk rollup |
|
📌 Commit 659028f has been approved by |
bors
added
S-waiting-on-bors
This was referenced Sep 25, 2020
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
Sep 26, 2020
… r=RalfJung,oli-obk Add `#![feature(const_fn_floating_point_arithmetic)]` cc rust-lang#76618 This is a template for splitting up `const_fn` into granular feature gates. I think this will make it easier, both for us and for users, to track stabilization of each individual feature. We don't *have* to do this, however. We could also keep stabilizing things out from under `const_fn`. cc @rust-lang/wg-const-eval r? @oli-obk
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 26, 2020
Rollup of 12 pull requests Successful merges: - rust-lang#75454 (Explicitly document the size guarantees that Option makes.) - rust-lang#76631 (Add `x.py setup`) - rust-lang#77076 (Add missing code examples on slice iter types) - rust-lang#77093 (merge `need_type_info_err(_const)`) - rust-lang#77122 (Add `#![feature(const_fn_floating_point_arithmetic)]`) - rust-lang#77127 (Update mdBook) - rust-lang#77161 (Remove TrustedLen requirement from BuilderMethods::switch) - rust-lang#77166 (update Miri) - rust-lang#77181 (Add doc alias for pointer primitive) - rust-lang#77204 (Remove stray word from `ClosureKind::extends` docs) - rust-lang#77207 (Rename `whence` to `span`) - rust-lang#77211 (Remove unused #[allow(...)] statements from compiler/) Failed merges: - rust-lang#77170 (Remove `#[rustc_allow_const_fn_ptr]` and add `#![feature(const_fn_fn_ptr_basics)]`) r? `@ghost`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #76618
This is a template for splitting up
const_fninto granular feature gates. I think this will make it easier, both for us and for users, to track stabilization of each individual feature. We don't have to do this, however. We could also keep stabilizing things out from underconst_fn.cc @rust-lang/wg-const-eval
r? @oli-obk